Repository navigation
📦 refactor: Move the Generation Run Atoms Into the Chat Package - #17140
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
berry-13
force-pushed
the
refactor/chat-generation-atoms
branch
from
October 15, 2026 16:09
72b0962 to
956c7ab
Compare
berry-13
force-pushed
the
refactor/chat-generation-atoms
branch
from
October 15, 2026 17:19
956c7ab to
0a83da8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
The pane run atoms (
submissionStartFamilyfor the elapsed indicator,showStopButtonByIndex,abortScrollFamily) are already Jotai, but they live in the app store (client/src/store/generation.ts), so every chat hook and component that reads them still imports from~/store, which the chat package is meant to stop doing.This moves them into the chat package's React entry (
packages/chat/src/react/generation.ts, exported from@librechat/chat/react) with their spec, and points every consumer at it: the SSE and chat hooks,useClearStates,ChatForm,Elapsedand their specs.jotaibecomes a peer (and dev) dependency of@librechat/chat, as the React bindings need. The abort-scroll latch drops its debug log line, since the package has no access to the app logger; nothing else changes.Type of change
Testing
Tested environments/configuration:
Not applicable: same atoms, same defaults, same writes; only where they are declared moves.
Automated tests:
generation.spec.tsmoved topackages/chat/src/react/__tests__/unchanged (3 pass).client: hooks/SSE, hooks/Chat, hooks/Config, Elapsed and the ChatForm specs: 64 suites, 1,661 tests pass.npx tsc --noEmitinpackages/chatandclient, eslint, prettier, sort-imports: clean. The lockfile change is the twojotaientries for@librechat/chatonly, with no internal registry URLs.Screenshots / recordings
No user-facing change.
Risk / compatibility
#17121 adds the same
jotaipeer and dev entries to@librechat/chat; the lines are identical, so whichever lands second merges cleanly or keeps one copy.Checklist