core: implement Gated trait and state machine (T0.3) - #2
Merged
alejandro-nexcade merged 1 commit intoJun 28, 2026
Merged
Conversation
Add gate.rs with the shared review loop trait. Pure state transitions (open, request_changes, approve, mark_reworked, mark_agent_failed) are default methods enforcing SPEC.md §7. Both Review and ProjectPlan implement the same trait — one loop, no forking. Stale flag logic is Review-specific. 34 new tests cover every legal and illegal transition, failure edges, comment clearing, and the stale flag. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
alejandro-nexcade
merged commit Jun 28, 2026
d0543d7
into
alejandro/t0.2-domain-model
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gate.rswith the sharedGatedtrait — one loop, written once (Invariant 3)open,request_changes,approve,mark_reworked,mark_agent_failedReviewandProjectPlanimplement the same trait; stale flag logic onReviewonlyTest plan
cargo fmt,cargo clippy -- -D warnings,cargo test --allgreen🤖 Generated with Claude Code