Function resolution and public introspection API - #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two changes driven by this discussion comment:
resolve_do_not_mock(item)exposes the resolved marker state of any collected item.Problem 1: aliased imports escaped protection
from myapp.payments import charge as my_chargecreates a second name for the same function object. The guard compared patch targets by module identity + attribute name, so:The escape existed in both string mode and object mode, and the escaping spelling is the idiomatic one (unittest.mock docs: "patch where it's used").
Fix: string targets resolve to the live object via
pkgutil.resolve_nameat enforcement time (collection still imports no application code), and matches_patch_target checksgetattr(target, attribute) is protected_objfirst, keeping the module+name check as a fallback for unresolved targets.Problem 2: no way for other tools to ask about the contract
The marker-stacking rules (union across scopes, bare marker wins, dedup) lived inline in the private hookwrapper. A test generator or another plugin wanting to respect the contract had to reimplement them.
Fix: new
contract.pywithresolve_do_not_mock(item) -> DoNotMockContract | None, safe to call at collection time. The hookwrapper is now a thin consumer of the same function.DoNotMockContract,ProtectedFuncandresolve_do_not_mockare exported from the package root.Behavior changes
DoNotMockErrorat test time instead of silently protecting nothing.