Remove requires_grad specification from meta functions #1769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanYashchuk
requested review from
mruberry,
lantiga and
t-vi
as code owners
This reverts commit 2b3828b.
for more information, see https://pre-commit.ci
crcrpar
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meta functions in Thunder should be straightforward and standalone for developers to implement them easily.
Some meta functions try to specify the
requires_gradattribute for output TensorProxies, but this attribute is never used in Thunder, and the correct propagation of it is not tested.The changes are needed to make the diff in #1599 cleaner. That PR tries to remove the
requires_gradattribute from TensorProxies.Let's discuss bringing back (and testing) of this attribute propagation in #1768.