benchmark_litgpt - update low_precision_mode accepted values
#1779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshitij12345
changed the title
low_precision_mode accepted values
|
cc: @AdamRajfer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With TE 2.0, the default recipe is chosen based on the platform
https://github.com/NVIDIA/TransformerEngine/blob/b39397c541292f336c5964dd1661d80c08dc4c78/transformer_engine/pytorch/fp8.py#L46-L51
For B200, it is MXFP8BlockScaling
For H100 and others, it is DelayedScaling
This PR updates
benchmark_litgpt.pyscript to update the accepted value for--low-precision-modefromfp8-delayed-teandfp8-delayed-te-wo_layernormtofp8-default-teandfp8-default-te-wo_layernormto hint at this.