Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split get_computation_and_inputs #1784

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Split get_computation_and_inputs #1784

wants to merge 7 commits into from

Conversation

t-vi
Copy link
Collaborator

@t-vi t-vi commented Feb 20, 2025 •
edited
Loading

Currently the function get_computation_and_inputs does three things:

  • acquisition of the initial trace by running the jit/interpreter,
  • application of the transforms and transform for execution etc. to get the prologue, computation, epilogue,
  • running the prologue and extracting the inputs for compute.

It can be useful to have the first two split, so that is what we do.

@t-vi t-vi marked this pull request as draft February 20, 2025 08:24
@IvanYashchuk IvanYashchuk removed their request for review February 24, 2025 09:14
@t-vi t-vi force-pushed the tom/split-get-computation-and-inputs branch from 5677c87 to 4279ea1 Compare February 26, 2025 11:20
@t-vi t-vi marked this pull request as ready for review February 28, 2025 21:54
@t-vi
Copy link
Collaborator Author

t-vi commented Mar 1, 2025

Seems to work, I'll add a test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mruberry mruberry Awaiting requested review from mruberry mruberry is a code owner

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@t-vi