Skip to content

Conversation

speediedan
Copy link
Contributor

@speediedan speediedan commented Aug 22, 2025

What does this PR do?

This versioning governance document update makes the following clarifications and minor updates:

  1. Clarifies the existing Lightning API evolution policy
  2. Makes the Compatiblity Matrix discussion more explicit with respect to expected PyTorch support ranges (while retaining flexibility)
  3. Bumps current 2.5.x support range to include PyTorch 2.8.0

Updates to the versioning governance revolve around the discussion in #21073 and should resolve that issue.

Fixes #21073

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21107.org.readthedocs.build/en/21107/

@github-actions github-actions bot added docs Documentation related pl Generic label for PyTorch Lightning package labels Aug 22, 2025
@speediedan speediedan marked this pull request as ready for review August 22, 2025 00:55
@Copilot Copilot AI review requested due to automatic review settings August 22, 2025 00:55
Copilot

This comment was marked as outdated.

simplify language

Co-authored-by: Copilot <[email protected]>
@Borda Borda requested a review from Copilot August 27, 2025 12:33
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the versioning governance document to clarify Lightning's API evolution policy and compatibility matrix. The changes simplify the API deprecation policy and make PyTorch support expectations more explicit.

Key changes:

  • Simplifies API evolution policy to limit breaking changes to major version upgrades only
  • Updates compatibility matrix to clarify PyTorch support expectations (latest 5 minor releases)
  • Updates PyTorch 2.5.x support range to include version 2.8.0

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Updated versioning information with last tested versions for various dependencies.
@Borda Borda merged commit a8f26e8 into Lightning-AI:master Aug 27, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related pl Generic label for PyTorch Lightning package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Versioning Policy Update
3 participants