-
Notifications
You must be signed in to change notification settings - Fork 3.6k
tests: fix skipif condition for deepspeed
#21195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
🌩️ Required checks status: Pending 🟡Groups summary🟢 pytorch_lightning: Tests workflow
These checks are required after the changes to 🟡 pytorch_lightning: lit GPU
These checks are required after the changes to 🟡 Benchmarks
These checks are required after the changes to 🟢 fabric: Docs
These checks are required after the changes to 🟢 lightning_fabric: CPU workflow
These checks are required after the changes to 🟡 lightning_fabric: lit GPU
These checks are required after the changes to 🟢 mypy
These checks are required after the changes to 🟢 install
These checks are required after the changes to Thank you for your contribution! 💜
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21195 +/- ##
========================================
- Coverage 87% 87% -1%
========================================
Files 269 269
Lines 23688 23688
========================================
- Hits 20666 20533 -133
- Misses 3022 3155 +133 |
for more information, see https://pre-commit.ci
…I/lightning into fix/skipif-deepspeed
for more information, see https://pre-commit.ci
…I/lightning into fix/skipif-deepspeed
Co-authored-by: Bhimraj Yadav <[email protected]>
Co-authored-by: Nicki Skafte Detlefsen <[email protected]>
What does this PR do?
seems it was falsely skipped, found while checking testing logs
required for #21194
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--21195.org.readthedocs.build/en/21195/