Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matplotlib example #2536

Closed
wants to merge 5 commits into from

Conversation

baskrahmer
Copy link
Collaborator

@baskrahmer baskrahmer commented May 13, 2024

What does this PR do?

Example of using Matplotlib animations in Sphinx-Gallery. Basically the only prerequisite is that matplotlib_animations is set to True in conf.py, which seems to already be the case :)

@Borda

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2536.org.readthedocs.build/en/2536/

@github-actions github-actions bot added the documentation Improvements or additions to documentation label May 13, 2024
Makefile Outdated Show resolved Hide resolved
@github-actions github-actions bot removed documentation Improvements or additions to documentation topic: Classif labels May 13, 2024
@SkafteNicki SkafteNicki added this to the v1.5.0 milestone Jul 22, 2024
@SkafteNicki
Copy link
Member

@baskrahmer what does the code have to do with torchmetrics? or is it just dummy code for now?

@baskrahmer
Copy link
Collaborator Author

@baskrahmer what does the code have to do with torchmetrics? or is it just dummy code for now?

Hey, it's just dummy code. Since we have some Matplotlib animations implemented in the documentation Gallery by now, this PR can be closed 😄

@baskrahmer baskrahmer closed this Jul 22, 2024
@Borda
Copy link
Member

Borda commented Jul 22, 2024

kind of, we used it to share how to nicely plot for the gallery, part of #2438 and #2508

@SkafteNicki
Copy link
Member

@baskrahmer what does the code have to do with torchmetrics? or is it just dummy code for now?

Hey, it's just dummy code. Since we have some Matplotlib animations implemented in the documentation Gallery by now, this PR can be closed 😄

Alright, fine by me 😄 but feel free to reopen if necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants