Skip to content

Bound better the loop size for the estimator to increase the shift #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ameligrana wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Bound better the loop size for the estimator to increase the shift #191

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2c2df03
Bound better the loop size for the estimator to increase the global s…
ameligrana Apr 18, 2026
66d58ba
Update WeightVectors.jl
ameligrana Apr 18, 2026
f537014
Update WeightVectors.jl
ameligrana Apr 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/WeightVectors.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,9 +484,10 @@ function set_global_shift_increase!(m::Memory{UInt64}, m5)
offset = 2m2+2093+2
checkbounds(m, offset-65*2:offset-2)

# TODO for perf, we can get away with shaving 1 to 10 off of these operations.
# This can underflow from significand sums into weights, but that underflow is safe because it can only happen if all the latter weights are zero. Be careful about this when re-arranging the memory layout!
Base.Cartesian.@nexprs 65 i -> (@inbounds x += m[offset - 2i] >> (i - 2))
for i in 1:(Base.top_set_bit(m[4])+1)
@inbounds x += m[offset - 2i] >> (i - 2)
end

# x is computed by rounding down at a certain level and then summing (and adding 1)
# m[5] will be computed by rounding up at a more precise level and then summing
Expand Down
Loading