Show a chat message when you are already connected.#1
Open
pvmac2194 wants to merge 1 commit intoLilyPad:masterfrom
pvmac2194:patch-1
Open
Show a chat message when you are already connected.#1pvmac2194 wants to merge 1 commit intoLilyPad:masterfrom pvmac2194:patch-1
pvmac2194 wants to merge 1 commit intoLilyPad:masterfrom
pvmac2194:patch-1
Conversation
This will hopefully eliminate confusion when a player tries to connect to a server they are already on, and nothing happens. This message is general, and you might want to add a configuration option for it, but this is just the gist of the idea.
Member
|
I think I'm going to do this but add a configuration option. |
Author
|
Alright, sounds good. My pull was just an idea. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will hopefully eliminate confusion when a player tries to connect to a server they are already on, and nothing happens. This message is general, and you might want to add a configuration option for it, but this is just the gist of the idea.