Add gc metric for allocation per second#323
Open
alfh wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For now, I just want feedback if this is something you also see as useful.
If you see it as useful, I will also add promotion per second.
The reason for having the alloction / promotion per second, is that when just using the "promotion" and "allocation" since last garbage collect, I get a constant number, for example 100MB of allocation, because the garbage collect kicks in after a number of bytes has been allocated. So sometimes there is 10 seconds between the garbage collect and sometimes there is 2 hours.
So I need the rate per second, to be able to see how "much" allocation is actually happening "per second".