fix!: better parameter & dependency management #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit performs a quite significant update of the SDK: - make sure the LinkupClient has the same parameter ordering as in the API documentation (might be breaking for users using only positional arguments) - delegate the choice of the default parameters to the API instead of re-implementating them (should not be breaking anything now, might be breaking in the future if the API defaults change themselves) - update the documentation
This minimal versions should not be very constraining, since they are quite old, but in theory this is still a breaking change.
vlapparov
reviewed
Sep 17, 2025
vlapparov
approved these changes
Sep 17, 2025
vlapparov
left a comment
vlapparov
left a comment
There was a problem hiding this comment.
LGTM. Not sure about the test case- need some clarification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR brings two quite important changes to the SDK, first around parameter management:
and around dependency management:
In the meantime, I updated the various docstrings to be more accurate and follow more systematically the google docstring convention.
Checklist
make install-devcommand)before creating any commit, or I have run successfully the
make lintcommand on my changesmake testcommand on my changesREADME.mdif my changes affected it