Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add browser chooser #41

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SebastienBtr
Copy link

I'm using this package to add Azure SSO authentication in an app, the workflow is exactly what I need, however, in order to pass security rules set in Azure, the login needs to be done through Microsoft Edge browser. The users know that they have to use Edge to login but they don't necessarily have it as their default browser so they need to be able to choose which browser to open for the authentication page.

For that, I added a boolean parameter showBrowserChooser, by default it will be set to false and everything will work as it is currently, but if this value is set to true and the user has multiple browser installed, a native browser chooser will show up to let the user select the browser to open.

I only implemented that for Android as I have no knowledge of Swift and I don't even know if something similar exist in iOS.

@LinusU LinusU force-pushed the master branch 2 times, most recently from 7a2dbbb to b0aa45d Compare April 6, 2021 08:00
@LinusU
Copy link
Owner

LinusU commented Sep 7, 2021

@SebastienBtr sorry for the super slow review on this one.

The code looks mostly good, would you be able to:

  1. Rebase on master
  2. Remove the hard wrapping of the comments
  3. Check if we can pass nil instead of "" as the title argument to Intent.createChooser

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants