qts-*: Test against QTS v4.5.6

Linuxfabrik · Nov 22, 2023 · c709ae4 · c709ae4
1 parent b27635a
commit c709ae4
Show file tree

Hide file tree

Showing 7 changed files with 9 additions and 9 deletions.
diff --git a/check-plugins/qts-cpu-usage/README.rst b/check-plugins/qts-cpu-usage/README.rst
@@ -8,7 +8,7 @@ Returns the current system-wide CPU utilization as a percentage from a QNAP Appl
 
 Hints and Recommendations:
 
-* Tested on `QuTScloud <https://www.qnap.com/en-us/download?model=qutscloud&category=firmware>`_ v5.1.
+* Tested on `QuTScloud <https://www.qnap.com/en-us/download?model=qutscloud&category=firmware>`_ v4.5.6+
 * The user used for monitoring must be a member of the "administrators" group. It is not sufficient to be a member of the "everyone" group.
 * ``--count=5`` (the default) while checking every minute means that the check reports a warning if the overall CPU usage is above a threshold in the last 5 minutes.
 

diff --git a/check-plugins/qts-disk-smart/README.rst b/check-plugins/qts-disk-smart/README.rst
@@ -10,7 +10,7 @@ This check does not run SMART itself. In order to get the latest values, schedul
 
 Hints and Recommendations:
 
-* Tested on `QuTScloud <https://www.qnap.com/en-us/download?model=qutscloud&category=firmware>`_ v5.1.
+* Tested on `QuTScloud <https://www.qnap.com/en-us/download?model=qutscloud&category=firmware>`_ v4.5.6+
 * The user used for monitoring must be a member of the "administrators" group. It is not sufficient to be a member of the "everyone" group.
 
 

diff --git a/check-plugins/qts-memory-usage/README.rst b/check-plugins/qts-memory-usage/README.rst
@@ -8,7 +8,7 @@ Returns the current system-wide memory utilization as a percentage from a QNAP A
 
 Hints and Recommendations:
 
-* Tested on `QuTScloud <https://www.qnap.com/en-us/download?model=qutscloud&category=firmware>`_ v5.1.
+* Tested on `QuTScloud <https://www.qnap.com/en-us/download?model=qutscloud&category=firmware>`_ v4.5.6+
 * The user used for monitoring must be a member of the "administrators" group. It is not sufficient to be a member of the "everyone" group.
 
 

diff --git a/check-plugins/qts-temperatures/README.rst b/check-plugins/qts-temperatures/README.rst
@@ -8,7 +8,7 @@ Checks system and CPU temperatures. All temperatures are expressed in celsius. T
 
 Hints and Recommendations:
 
-* Tested on `QuTScloud <https://www.qnap.com/en-us/download?model=qutscloud&category=firmware>`_ v5.1.
+* Tested on `QuTScloud <https://www.qnap.com/en-us/download?model=qutscloud&category=firmware>`_ v4.5.6+
 * The user used for monitoring must be a member of the "administrators" group. It is not sufficient to be a member of the "everyone" group.
 
 

diff --git a/check-plugins/qts-uptime/README.rst b/check-plugins/qts-uptime/README.rst
@@ -8,7 +8,7 @@ Checks and tells how long the system has been running (in days).
 
 Hints and Recommendations:
 
-* Tested on `QuTScloud <https://www.qnap.com/en-us/download?model=qutscloud&category=firmware>`_ v5.1.
+* Tested on `QuTScloud <https://www.qnap.com/en-us/download?model=qutscloud&category=firmware>`_ v4.5.6+
 * The user used for monitoring must be a member of the "administrators" group. It is not sufficient to be a member of the "everyone" group.
 
 

diff --git a/check-plugins/qts-version/README.rst b/check-plugins/qts-version/README.rst
@@ -8,7 +8,7 @@ This plugin lets you track if a QTS update is available. To check for updates, t
 
 Hints and Recommendations:
 
-* Tested on `QuTScloud <https://www.qnap.com/en-us/download?model=qutscloud&category=firmware>`_ v5.1.
+* Tested on `QuTScloud <https://www.qnap.com/en-us/download?model=qutscloud&category=firmware>`_ v4.5.6+
 * Does not work on QTS 4.3 or less (see `#701 <https://github.com/Linuxfabrik/monitoring-plugins/issues/701>`_ for details).
 * The user used for monitoring must be a member of the "administrators" group. It is not sufficient to be a member of the "everyone" group.
 
@@ -61,7 +61,7 @@ Output:
 
 .. code-block:: text
 
-    QTS vc5.1.0.2498 Build 20230822 is up to date
+    QTS vc5.0.1.2374 Build 20230419 installed, QTS vc5.1.0.2498 Build 20230822 available
 
 
 States

diff --git a/check-plugins/qts-version/qts-version b/check-plugins/qts-version/qts-version
@@ -151,8 +151,8 @@ def main():
     )
     xmldict = xmltodict.parse(result)['QDocRoot']
     if 'newVersion' in xmldict['func']['ownContent']:
-        # versions prior to 5.0.1
-        latest_version = xmldict['newVersion']
+        # versions up to 5.0.1
+        latest_version = xmldict['func']['ownContent']['newVersion']
     elif 'version' in xmldict['firmware']:
         # version 5.0.1+
         latest_version = xmldict['firmware']['version']