feat: make idempotency response persistence reliable with defined replay states#499
Merged
mikewheeleer merged 1 commit intoJun 28, 2026
Conversation
|
@christy-dev4 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
…lay states - Add retry-with-backoff for response storage (max 5 attempts, exponential backoff) - Mark keys with response_status=-1 when storage fails to indicate incomplete state - Re-execute handler on replay when key has incomplete response (safe recovery) - Add idempotency_storage_failure_total metric for storage failures - Add comprehensive tests for storage failure and replay scenarios - Document idempotency state machine in JSDoc comments Closes Liquifact#428
christy-dev4
force-pushed
the
enhancement/idempotency-reliable-response-storage
branch
from
528d688 to
7e7d10a
Compare
Contributor
|
nice work — merging this 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #428 by implementing reliable idempotency response persistence.
Changes
Idempotency State Machine
The middleware now defines explicit states for idempotency keys:
Reliability Improvements
Metrics
Added counter to track storage failures after max retries (labels: for first 8 chars of key)
Tests
Comprehensive test suite covers:
Closes #428