[codex] validate fund invoice stroops as BigInt strings#546
Open
MyouzzZ wants to merge 1 commit into
Open
Conversation
60348bc to
fe0bc4e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #506
Summary
validateAmountStroopsBigInt validator inPOST /api/invest/fund-invoiceinstead of coercing throughNumber().amountStroopsas a strict decimal string through the funding path and reject JSON numbers, signs, decimals, scientific notation, leading zeros, zero, and values above10^18before escrow submission or persistence.amountStroopscontract in README and the route OpenAPI block, with focused route/service tests.Tests
npm test -- --silent tests/invest.fund.test.js tests/investorCommitment.validation.test.js tests/escrowSubmit.amount.test.js tests/escrow.derived.test.jsnpx eslint src/routes/invest.js src/services/investorCommitment.js src/services/escrowSubmit.js src/middleware/kycGating.js src/middleware/requestId.js src/middleware/correlationId.js src/metrics.js src/logger.js tests/invest.fund.test.js tests/escrowSubmit.amount.test.js