test: cover update_maturity_max_horizon bounds and downstream maturity validation#550
Merged
mikewheeleer merged 1 commit intoJun 28, 2026
Conversation
…y validation Add focused tests in escrow/src/tests/admin.rs asserting the full behavioural contract of update_maturity_max_horizon and its interaction with update_maturity: - Admin gate: unauthorized callers are rejected (require_auth enforced) - Event emission: mtry_max event carries correct old and new horizon values - Default fallback: get_maturity_max_horizon returns DEFAULT_MATURITY_MAX_HORIZON_SECS when no explicit horizon has been stored - Security invariant: lowering the horizon does not retroactively invalidate an already-set maturity; the stored maturity remains unchanged after the horizon update - Rejection after lowering: a subsequent update_maturity targeting now + new_horizon + 1 is rejected, and the stored maturity stays intact after the failed call - Within-horizon success: an update_maturity within the lowered ceiling still succeeds Also includes formatting fixes across several test modules to satisfy cargo fmt.
|
@dotmantissa Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
looks good — in it goes 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add focused tests in escrow/src/tests/admin.rs asserting the full behavioural contract of update_maturity_max_horizon and its interaction with update_maturity:
Also includes formatting fixes across several test modules to satisfy cargo fmt.
Closes #479