feat: add pending admin remaining time view#596
Open
webmirroring wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #552
Summary
get_pending_admin_remaining_secs() -> Option<u64>as a pure read view for pending admin handover validity.accept_admin:now == expiryreturnsSome(0)while still acceptable, andnow > expiryreturnsSome(0)whileaccept_adminrejects.Security notes
PendingAdminbefore reporting any remaining time so inactive handovers returnNone.saturating_subto avoid underflow after expiry.Validation
git diff --checkcargo test -p liquifact_escrow pending_admin_remaining -- --nocapturecargo 1.84.0/rustc 1.84.0.base64ct v1.8.3requires Cargo's stabilized edition2024 support from newer Cargo.cargo fmt -p liquifact_escrow -- --checkescrow/src/tests/funding.rs,integration_status_guards.rs,properties.rs, and existing lines inescrow/src/lib.rs.