feat: add bounded batch contribution read view#597
Open
webmirroring wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #553.
Summary
MAX_INVESTOR_READ_BATCHand a pure read-onlyget_contributions(Vec<Address>) -> Vec<i128>view.get_contributionstorage reads, returns0for unknown addresses, and rejects oversized batches withEscrowError::ContributionReadBatchTooLarge.CI unblock notes
cargo fmt -p liquifact_escrowbecause CI checks the whole escrow package and main currently contains rustfmt diffs.guard_status_eq/guard_status_inhelper definitions and added missing operational-pause typed errors so whole-package clippy can compile this branch.HorizonNotRaisedto a non-conflicting code (204) to avoid the existing duplicate discriminant withLegalHoldBlocksPartialSettle.Security notes
0default asget_contribution, so the view cannot panic on absent contribution storage.Validation
cargo fmt -p liquifact_escrow -- --checkgit diff --checkcargo test -p liquifact_escrow get_contributions -- --nocapture, but this local machine has Cargo 1.84.0 and fails before compiling becausebase64ct v1.8.3requires edition2024 / Cargo 1.85+.