### Pull Request Title: refactor: single-source mock invoices from app/invest/lib.js#381
Open
SHEROSE0 wants to merge 1 commit into
Open
### Pull Request Title: refactor: single-source mock invoices from app/invest/lib.js#381SHEROSE0 wants to merge 1 commit into
refactor: single-source mock invoices from app/invest/lib.js#381SHEROSE0 wants to merge 1 commit into
Conversation
Removes inline MOCK_INVOICES and loadMockInvoices from app/invest/page.js to prevent data drift. Establishes app/invest/lib.js as the single source of truth for mock data.
Hilary017
pushed a commit
to Hilary017/Liquifact-frontend
that referenced
this pull request
Jun 30, 2026
…-signature-delegate feat: implement ephemeral signature delegate support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#closes #186
Description
This PR resolves the issue of duplicated mock invoice data across the codebase. Previously,
MOCK_INVOICESandloadMockInvoiceswere defined in bothapp/invest/lib.jsandapp/invest/page.js, leading to potential data drift and maintenance overhead.This change establishes
app/invest/lib.jsas the canonical source of truth.Changes
MOCK_INVOICES,loadMockInvoices, andDEV_DELAYdeclarations fromapp/invest/page.js.app/invest/page.jsto import these assets directly from./lib.app/invest/lib.jsand updateddocs/api-integration.mdto clarify the data sourcing strategy for future contributors.app/invest/page.test.jsxto validate that the marketplace list correctly renders from the shared fixture.Testing & Validation
npm run lintpassed.npm run buildcompleted successfully.MOCK_INVOICESis now only defined once in the repository.Acceptance Criteria Checklist
page.js.lib.js.window.__TEST_MOCK_INVOICES__.docs/api-integration.md.#closes