feat: show narrator in Library Import match result cards (#552) #692
Open
NourdotSiwar wants to merge 2 commits into
Open
feat: show narrator in Library Import match result cards (#552) #692NourdotSiwar wants to merge 2 commits into
NourdotSiwar wants to merge 2 commits into
Conversation
added 2 commits
June 19, 2026 21:33
Import extractNarrators helper and render narrator line on each result card in the Library Import match modal. Uses conditional span with result-narrator CSS class matching the existing meta style. Fixes Listenarrs#552
…tSearchModal Adds two unit tests: - Narrator renders when result includes narrator data - Result thumbnails route through the protected image helper
NourdotSiwar
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #552 by enhancing the Library Import “Find Match” modal so each search result card also displays narrator information, making it easier to distinguish between multiple recordings of the same title.
Changes:
- Added a “Narrated by …” line to each result card in
LibraryImportSearchModal.vueusing the existingextractNarrators()helper. - Added a unit test asserting narrator display in
LibraryImportSearchModal.spec.ts.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
fe/src/components/domain/audiobook/LibraryImportSearchModal.vue |
Renders narrator text on match result cards using extractNarrators(result) and adds scoped styling for the narrator line. |
fe/src/__tests__/LibraryImportSearchModal.spec.ts |
Adds a unit test to verify narrator text is shown when narrator data is present in results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #552. The Library Import match modal showed result cards with title, author, and ASIN but never displayed the narrator, making it impossible to distinguish between multiple recordings of the same title read by different narrators.
Changes
Added
Narrated by …) on each result card inLibraryImportSearchModal.vue, rendered via the existingextractNarrators()helperLibraryImportSearchModal.spec.tsTesting
cd fe && npm run type-check— no errorscd fe && npm run test:unit— all relevant tests passNotes
No backend changes required — narrator data is already returned by the /search endpoint. Pattern mirrors the existing narrator rendering in
AddNewView.vue.