Conversation
This should be a good enough replacement for upgrade logic where users were expected to throw away the settings.ini they had, copy the one pre-bundled and then modify it to match the same behavior as earlier. This should be additive in nature, not subtractive
This is to prepare the stage for removing the pre-baked settings.ini file altogether. This check is too early, before there is an attempt to read (and therefore generate) a valid settings.ini so it'll try to substitute a pair in an empty file... Let LES write default values, then prompt the user.
One of Lua's pitfalls is that everything can be a global by default, it makes understanding the initialization process a bit of a PITA. To work despite that, we're trying to make the best of the pseudo-OOP that Lua provides. We'll slowly try to streamline and document the initialization sequence, changing it if we have to. For instance, we're doing the settings read _before_ the macOS and Live sanity check and _well before_ we're reading the menuconfig. The reason will be apparent in subsequent commits.
§ is only available on certain European layouts, ` is available on most layouts, including the more popular US layout. It makes sense for a sane default to be based on the US layout rather than the European one.
|
Thank you for your contribution! I'd have to borrow a Mac to compile and test the fixes, that's primarily why code contributions on my end haven't happened in a while but in the meanwhile, is it possible to get in contact with the author of the fix so that they can give permission to use it? |
|
Hey this is Orphin on Reddit this fix has worked on my M1 Pro Chip |
|
Thank you! Am currently fixing up a Mac, will be rebasing on top latest Hammerspoon (1.0.0 vs current base of 0.9.99) and improving Live version detection (reading from |
|
@dharit-tan Please consider basing your PR on |
4 participants
Uh oh!
There was an error while loading. Please reload this page.