fix(package/linux): update desktop metainfo #3901
Open
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReenigneArcher
changed the title
1. By default the .desktop file gets installed to sunshine.desktop, as such provide the launchable tag for it to help `appstream-builder` "find" the .desktop file due to the id (Sunshine.desktop) not matching. Rename the id to just @PRODUCT_NAME@ as well since the .desktop suffix is no longer required. Provide URL as well. Spec: https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-launchable Fixes appstream-builder generation. 2. Set the metadata_license to FSFAP. To be valid, it has to be one of the licenses vetted by the spec, otherwise `appstreamcli-compose` will error. Spec: https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-metadata_license Fixes generation with `appstreamcli-compose` and thus distros which use `appstream-generator`.
joebonrichie
force-pushed
the
appstream-builder
branch
from
5e2a709 to
c97770e
Compare
If possible it's better to consolidate as much as possible the xml metainfo files if they're different. If it passes |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
appstream-builder"find" the .desktop file due to the id (Sunshine.desktop) not matching.Rename the id to just @PRODUCT_NAME@ as well since the .desktop suffix is no longer required.
Provide URL as well.
Spec: https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-launchable
Fixes
appstream-buildergeneration.appstreamcli-composewill error.Spec: https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-metadata_license
Fixes generation with
appstreamcli-composeand thus distros which useappstream-generator.Screenshot
N/A
Issues Fixed or Closed
Follow up to #2006.
Type of Change
.github/...)