Skip to content

feat(installer/windows): add wix installer #3916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented May 26, 2025

Description

This PR adds a WIX installer for Sunshine. The NSIS installer will be removed at a later point after any bugs with the WIX installer are ironed out.

This is a requirement for having an ARM64 installer for #3905 or #3369

TODO:

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@ReenigneArcher ReenigneArcher force-pushed the feat/installer/windows/add-wix-installer branch 4 times, most recently from 14ce5ed to f20af0e Compare May 27, 2025 00:11
Copy link

codecov bot commented May 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.51%. Comparing base (356545f) to head (6ef5e6e).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3916   +/-   ##
=======================================
  Coverage   11.51%   11.51%           
=======================================
  Files          92       92           
  Lines       17499    17499           
  Branches     8152     8152           
=======================================
  Hits         2015     2015           
  Misses      12988    12988           
  Partials     2496     2496           
Flag Coverage Δ
Linux 11.14% <ø> (ø)
Windows 12.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link

codecov bot commented May 27, 2025

Bundle Report

Bundle size has no change ✅

@ReenigneArcher ReenigneArcher force-pushed the feat/installer/windows/add-wix-installer branch 4 times, most recently from 1d10b2b to 9e4b955 Compare May 27, 2025 01:29
@ReenigneArcher ReenigneArcher force-pushed the feat/installer/windows/add-wix-installer branch from 9e4b955 to 6ef5e6e Compare May 27, 2025 02:01
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sunshine: change windows installer to WiX
1 participant