Address PR review comments: Remove debug code, fix types, align config#59
Merged
AAllport merged 2 commits intofeature/2026-updatesfrom Feb 1, 2026
Merged
Address PR review comments: Remove debug code, fix types, align config#59AAllport merged 2 commits intofeature/2026-updatesfrom
AAllport merged 2 commits intofeature/2026-updatesfrom
Conversation
Co-authored-by: AAllport <3750120+AAllport@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update dependencies for Nuxt 4 upgrade and related changes
Address PR review comments: Remove debug code, fix types, align config
Feb 1, 2026
There was a problem hiding this comment.
Pull request overview
This pull request prepares the codebase for a Nuxt 4 upgrade by cleaning up code quality issues, fixing environment variable handling, and aligning dependency versions with the project's catalog configuration.
Changes:
- Fixed spelling error in vitest.config.ts comment ("readably" → "incredibly")
- Updated nuxt.config.ts to use
process.envinstead ofimport.meta.envfor proper Node.js environment variable access - Aligned @nuxt/test-utils version to 3.17.2 across both configurator and components packages to match catalog
- Added missing semicolon in PadCfg.ts for code style consistency
- Removed debug console.log statements and added explicit typing for colorMode variable in DeckIconPicker component
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/localdeck-configurator/vitest.config.ts | Corrected spelling in comment from "readably" to "incredibly" |
| packages/localdeck-configurator/nuxt.config.ts | Updated environment variable check from import.meta.env to process.env for proper Node.js configuration file usage |
| packages/localdeck-configurator/.nuxtrc | Aligned @nuxt/test-utils version from 3.23.0 to 3.17.2 to match catalog specification |
| packages/localdeck-components/src/utils/PadCfg.ts | Added missing semicolon to import statement for consistency with project's eslint rules |
| packages/localdeck-components/src/components/DeckIconPicker.client.vue | Removed debug console.log statements and added explicit TypeScript type for colorMode variable |
| packages/localdeck-components/.nuxtrc | Aligned @nuxt/test-utils version from 3.23.0 to 3.17.2 to match catalog specification |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applied changes from PR review thread addressing code quality and configuration alignment issues.
Code cleanup:
console.logstatements fromDeckIconPicker.client.vueReturnType<typeof useColorMode> | nulltype annotation to prevent TypeScriptanyinferencePadCfg.tsimport for ESLintsemi: truecomplianceConfiguration alignment:
.nuxtrcfiles to use@nuxt/test-utils@3.17.2matching workspace catalognuxt.config.tsconditional module loading fromimport.meta.env.TESTtoprocess.env.TEST || process.env.VITESTfor Node runtime compatibilityMinor fixes:
vitest.config.tscomment: "readably slow" → "incredibly slow"✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.