feat: 缩小快捷选择判定区 - #144
Open
BiologyHazard wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
本次 PR 主要针对设置页的“武器类型快捷全选”交互区域进行调整,以缩小可点击判定区域;同时包含一处与“非无瑕基质处理”相关的文案调整。
Changes:
- 将武器类型分组的全选触发从
v-checkbox的点击,改为点击标题容器触发,并新增.group-title { width: fit-content; }以缩小点击区域。 - 调整“遇到非无瑕基质时”的问题描述与单选项文案。
Comments suppressed due to low confidence (1)
frontend/src/pages/settings.vue:49
- 这里用外层
<h3>包住v-checkbox并绑定@click,同时在prepend里又嵌套了一个<h3>(<h3>里套<h3>)。这会产生不合法的标题层级/语义结构,且把交互控件放进标题元素对可访问性不友好。建议把外层容器改为div/span(或使用按钮语义的元素),并只保留一个真正的标题元素;点击/切换逻辑尽量绑定到v-checkbox的值更新事件上。
<h3
class="group-title"
@click="typeSelectAll(weaponType.id, !isTypeAllSelected(weaponType.id))"
>
<v-checkbox
density="compact"
hide-details
:indeterminate="isTypePartiallySelected(weaponType.id)"
:model-value="isTypeAllSelected(weaponType.id)"
>
<template #prepend>
<img
:alt="weaponType.name"
class="group-icon me-2"
:src="weaponType.iconUrl"
:style="{
filter: theme.current.value.dark ? 'none' : 'invert(1)',
}"
/>
<h3 class="ma-0">{{ weaponType.name }}</h3>
</template>
</v-checkbox>
</h3>
| <v-radio-group v-model="nonFiveStarBehavior" color="primary" density="comfortable" inline> | ||
| <v-radio label="跳过对它的操作" value="skip" /> | ||
| <v-radio label="继续操作(当作无瑕基质进行操作)" value="process" /> | ||
| <v-radio label="停止识别" value="skip" /> |
Comment on lines
+308
to
+311
| <h2>遇到非无瑕基质时,该如何操作?</h2> | ||
| <v-radio-group v-model="nonFiveStarBehavior" color="primary" density="comfortable" inline> | ||
| <v-radio label="跳过对它的操作" value="skip" /> | ||
| <v-radio label="继续操作(当作无瑕基质进行操作)" value="process" /> | ||
| <v-radio label="停止识别" value="skip" /> | ||
| <v-radio label="继续识别" value="process" /> |
| $weapon-icon-size: clamp(3rem, 16vw, 6rem); | ||
|
|
||
| .group-title { | ||
| width: fit-content; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.