Skip to content

feat: 缩小快捷选择判定区 - #144

Open
BiologyHazard wants to merge 1 commit into
devfrom
bio/frontend
Open

feat: 缩小快捷选择判定区#144
BiologyHazard wants to merge 1 commit into
devfrom
bio/frontend

Conversation

@BiologyHazard

Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings March 13, 2026 16:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

本次 PR 主要针对设置页的“武器类型快捷全选”交互区域进行调整,以缩小可点击判定区域;同时包含一处与“非无瑕基质处理”相关的文案调整。

Changes:

  • 将武器类型分组的全选触发从 v-checkbox 的点击,改为点击标题容器触发,并新增 .group-title { width: fit-content; } 以缩小点击区域。
  • 调整“遇到非无瑕基质时”的问题描述与单选项文案。
Comments suppressed due to low confidence (1)

frontend/src/pages/settings.vue:49

  • 这里用外层 <h3> 包住 v-checkbox 并绑定 @click,同时在 prepend 里又嵌套了一个 <h3><h3> 里套 <h3>)。这会产生不合法的标题层级/语义结构,且把交互控件放进标题元素对可访问性不友好。建议把外层容器改为 div/span(或使用按钮语义的元素),并只保留一个真正的标题元素;点击/切换逻辑尽量绑定到 v-checkbox 的值更新事件上。
            <h3
              class="group-title"
              @click="typeSelectAll(weaponType.id, !isTypeAllSelected(weaponType.id))"
            >
              <v-checkbox
                density="compact"
                hide-details
                :indeterminate="isTypePartiallySelected(weaponType.id)"
                :model-value="isTypeAllSelected(weaponType.id)"
              >
                <template #prepend>
                  <img
                    :alt="weaponType.name"
                    class="group-icon me-2"
                    :src="weaponType.iconUrl"
                    :style="{
                      filter: theme.current.value.dark ? 'none' : 'invert(1)',
                    }"
                  />
                  <h3 class="ma-0">{{ weaponType.name }}</h3>
                </template>
              </v-checkbox>
            </h3>

<v-radio-group v-model="nonFiveStarBehavior" color="primary" density="comfortable" inline>
<v-radio label="跳过对它的操作" value="skip" />
<v-radio label="继续操作(当作无瑕基质进行操作)" value="process" />
<v-radio label="停止识别" value="skip" />
Comment on lines +308 to +311
<h2>遇到非无瑕基质时,该如何操作?</h2>
<v-radio-group v-model="nonFiveStarBehavior" color="primary" density="comfortable" inline>
<v-radio label="跳过对它的操作" value="skip" />
<v-radio label="继续操作(当作无瑕基质进行操作)" value="process" />
<v-radio label="停止识别" value="skip" />
<v-radio label="继续识别" value="process" />
$weapon-icon-size: clamp(3rem, 16vw, 6rem);

.group-title {
width: fit-content;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants