Skip to content

Change _makeQuery from private to protected and export QueryOptions #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

zygopleural
Copy link

@zygopleural zygopleural commented Jun 13, 2025

Pull Request

Description

This PR changes the _makeQuery function from private to protected to allow the LoopsClient to be extended and _makeQuery to be enhanced. It also exports the QueryOptions interface.

For example:

import { LoopsClient as ActualLoopsClient, QueryOptions } from 'loops';

import { logger } from '@/utils/logger';

export class LoopsClient extends ActualLoopsClient {
  async _makeQuery<T>(options: QueryOptions): Promise<T> {
    try {
      return await super._makeQuery<T>(options);
    } catch (error) {
      logger.error('Error making loops query', {
        options,
        error,
      });
      throw error;
    }
  }
}

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

N/A

Checklist:

Before you submit this PR, please check off items you have completed:

  • I have read the CONTRIBUTING.md document
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

@zygopleural zygopleural force-pushed the protected_makeQuery branch from ab1f51d to 1ae883b Compare June 13, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant