Strip leftover scaffolding refs; delete abandoned regression_report - #47
Merged
Merged
Conversation
…eport Docs/comments and one dead-file deletion only; no behavior change. Extracts the still-applicable hygiene from the superseded #36, whose stale branch carried the whole Phase 1-6 review stack that has since merged piecemeal. - Delete tests/regression_report.py: abandoned scaffolding (a placeholder parse_pytest_output returning hardcoded zeros, no callers, docstrings referencing an external workflow that does not ship with the library). - Strip lingering "Tier 1/2/3" and "issue #26" scaffolding references from models/base.py comments and two test files, keeping the substantive text. `grep -E "Tier [123]|issue #26" src/` is now empty. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
5 tasks
Removes docs/plans/2025-10-23-comprehensive-regression-detection.md, the implementation-plan doc that proposed the now-deleted tests/regression_report.py scaffolding. The system it describes was only ever stubbed, nothing references the doc, and it carries a hardcoded local conda path — a stale historical snapshot. Completes removing the abandoned regression-detection scaffolding (module + its plan). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The still-applicable hygiene from the now-closed #36, re-cut fresh against current
main(rather than reconciling #36's ~50-file / 37-conflict stale branch, which carried the whole Phase 1–6 review stack that has since merged piecemeal). Docs/comments and dead-scaffolding deletion only — no behavior change.tests/regression_report.py— abandoned, never-collected scaffolding: the filename doesn't matchtest_*.py, and it has notest_functions or assertions, so pytest never ran it. It's aRegressionReportformatter dataclass plus loader stubs returning empty/zeroed placeholders (parse_pytest_summary→ all-zero counts,load_*→{}/[]); its one real code path imported a nonexistenttest_api_surfaceand always failed (swallowed by a bare except). No callers, no CI references, no runtime imports.docs/plans/2025-10-23-comprehensive-regression-detection.md— the implementation-plan doc that proposed that module. The system it describes was only ever stubbed, nothing references the doc, and it carries a hardcoded local conda path — a stale historical snapshot. (The otherdocs/plans/*files are left as-is.)"Tier 1/2/3"comments and"issue #26"references inmodels/base.pyand two test files, keeping the substantive comment text (e.g.# Validate all parameters early (Tier 1 & 2)→# Validate all parameters early).grep -E "Tier [123]|issue #26" src/is now empty.Verify
ruff checkclean.pytest --cocollects 1219 tests (no orphaned import of the deleted file).Closes #36.
🤖 Generated with Claude Code