Skip to content

Ingest trials and structured behavior - #1349

Draft
CBroz1 wants to merge 10 commits into
LorenFrankLab:masterfrom
CBroz1:iti
Draft

CBroz1 wants to merge 10 commits into
LorenFrankLab:masterfrom
CBroz1:iti

Conversation

@CBroz1

@CBroz1 CBroz1 commented Jul 16, 2025 •

Copy link
Copy Markdown
Member

Description

This PR aims to address...

Previous discussion points:

  • Move to common_task or common_behav? No, keep independent schema for a given nwb extension
  • Change to Imported table? No, planning to integrate into SpyglassIngestion pending Standardize nwb ingestion #1377
  • Ingest each item as an interval list? No, that would be excessive. Downstream tables should selectively insert

Checklist:

  • No. This PR should be accompanied by a release: (yes/no/unsure)
  • N/a. If release, I have updated the CITATION.cff
  • No. This PR makes edits to table definitions: (yes/no)
  • N/a. If table edits, I have included an alter snippet for release notes.
  • N/a. If this PR makes changes to position, I ran the relevant tests locally.
  • I have updated the CHANGELOG.md with PR number and description.
  • I have added/edited docs/notebooks to reflect the changes

Comment thread src/spyglass/common/common_task_rec.py Outdated
Comment thread src/spyglass/common/common_task_rec.py Outdated
Comment thread src/spyglass/common/common_task_rec.py Outdated
CBroz1 and others added 2 commits July 25, 2025 11:00
Co-authored-by: Szonja Weigl <weigl.anna.szonja@hallgato.ppke.hu>
@edeno edeno linked an issue Aug 11, 2025 that may be closed by this pull request
Comment thread src/spyglass/common/common_task_rec.py Outdated
Comment thread src/spyglass/common/common_interval.py
Comment thread src/spyglass/common/common_interval.py
@CBroz1 CBroz1 linked an issue Sep 11, 2025 that may be closed by this pull request
@weiglszonja

weiglszonja commented May 19, 2026 •

Copy link
Copy Markdown

Hey @CBroz1 ,

I'm currently relying on this branch for the ndx_structured_behavior support in catalystneuro/pagan-lab-to-nwb#3. I wanted to check in on the PR status, since it's been in draft for a while and has drifted from upstream main.

Is there anything blocking the PR from being merged into main?

If the PR is far from being merged, I'd consider switching to my own fork (here) to have a stable base.

Thanks!

@CBroz1 CBroz1 added the Blocker Progress here is blocked by some dependency (e.g., nwb extension), discussion, or external approval label Jun 16, 2026
@CBroz1 CBroz1 added this to the Future milestone Jun 16, 2026
@CBroz1

CBroz1 commented Jul 30, 2026

Copy link
Copy Markdown
Member Author

Is there anything blocking the PR from being merged into main?

Yes, we're waiting on the pypi release of the extension, so that everything remains pip installable. I don't have a good sense from @rly as to when that might happen

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Blocker Progress here is blocked by some dependency (e.g., nwb extension), discussion, or external approval

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for structured behavioral data Insert invalid_times to IntervalList

2 participants