[pull] master from oe-alliance:master#233
Merged
Merged
Conversation
Sky DE wraps service names in DVB emphasis bytes (0x86/0x87 in the C1 control range) around the actual text, on top of a leading charset indicator (0x05 in the C0 range). The SDT parser in dvbreader.c only strips the first leading control byte, so service names like "\x05\x86Sky\x87 \x86Showcase\x87" reach the CustomLCN writer as "\x86Sky\x87 \x86Showcase\x87" after six.ensure_text decodes them to Unicode (U+0086 / U+0087). Those codepoints then appear as UTF-8 "\xc2\x86" / "\xc2\x87" pairs in the generated EXAMPLE_*_CustomLCN.xml files — unreadable garbage for maintainers opening the file in an editor. Strip every C0 and C1 control character (U+0000..U+001F, U+007F..U+009F) from the description before writing, using the already-imported re module. No effect on the runtime service name used in bouquets, only on what ABM writes into its example files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )