Let recording be scoped, and name what is not being checked - #22
Merged
Conversation
Two changes, both about the user knowing what a verdict covers. Recording was all-or-nothing per package, so one noisy or vendored module could dominate a recording with no way to leave it out. `nodrift record` now takes --include and --exclude as fnmatch patterns against the full `module:Qualname` target, so a subpackage, a module or a single method can be named. Excludes win over includes, since the point of naming one is to keep it out, and the count of skipped callables is printed rather than left to show up as a quietly smaller recording. `check` reported quarantined records as a bare count. "47 records quarantined" says nothing about whether the function you care about stopped being checked, so the targets are now named - the first three inline, all of them under --verbose. Closes #10 Refs #12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes, both about the user knowing what a verdict covers.
Recording was all-or-nothing per package, so one noisy or vendored module
could dominate a recording with no way to leave it out.
nodrift recordnowtakes --include and --exclude as fnmatch patterns against the full
module:Qualnametarget, so a subpackage, a module or a single method can benamed. Excludes win over includes, since the point of naming one is to keep
it out, and the count of skipped callables is printed rather than left to
show up as a quietly smaller recording.
checkreported quarantined records as a bare count. "47 recordsquarantined" says nothing about whether the function you care about stopped
being checked, so the targets are now named - the first three inline, all of
them under --verbose.
Closes #10
Refs #12