Reset the random streams before every replayed record - #25
Merged
Conversation
random.seed(0) ran once per replay process, so the records shared one stream. A candidate that changes how many values one function draws shifts every record after it, and a function nobody touched is reported as different. Reproduced with two functions, one drawing randoms and one merely formatting one: adding a single extra draw to the first made the second report 2 of 2 inputs differ. It was never edited. That is a false positive, which is the one error this tool cannot afford, and it was reachable by any refactor touching random use. Reseeding per record costs nothing and hides nothing: a function that stops using randomness still returns something other than the seeded value, so real changes are still caught. The regression test is the reproduction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
random.seed(0) ran once per replay process, so the records shared one stream.
A candidate that changes how many values one function draws shifts every
record after it, and a function nobody touched is reported as different.
Reproduced with two functions, one drawing randoms and one merely formatting
one: adding a single extra draw to the first made the second report 2 of 2
inputs differ. It was never edited.
That is a false positive, which is the one error this tool cannot afford, and
it was reachable by any refactor touching random use. Reseeding per record
costs nothing and hides nothing: a function that stops using randomness still
returns something other than the seeded value, so real changes are still
caught. The regression test is the reproduction.