Avoids errors when Extracting PHARs in class BinaryInstaller.php line 214 (PharData decompressing)

[beto-aveiga]

Description

It avoids errors when extracting PHARs.
Possibly related to: https://bugs.php.net/bug.php\?id\=75101

More information in the linked ticket below.

Solves

#135

[deviantintegral]

@beto-aveiga does #207 avoid this issue for you?

[beto-aveiga]

@deviantintegral
I haven't tried it, but I checked the PR and think it won't work.
I updated the description of this PR so you know what issue it is solving.

[beto-aveiga]

Opening

[beto-aveiga]

@deviantintegral @justafish I just tried this today. I could replicate the PHAR extracting in Tugboat, then added it to the composer file and work. Please review this. Many thanks!

[beto-aveiga]

FYI this is the error I was having in Tugboat:

- Skip [web-root]/modules/README.txt: overridden in abcd/xyz.org-cms
- Skip [web-root]/profiles/README.txt: overridden in abcd/xyz.org-cms
- Skip [web-root]/themes/README.txt: overridden in abcd/xyz.org-cms
Scaffolding files for lullabot/drainpipe:
- Skip [project-root]/.env because it already exists and overwrite is false.
> cd web && patch -p1 <../patches/htaccess-modifications.patch
patching file .htaccess
Updating BLT template files...
> blt blt:update --ansi --no-interaction
> blt:init:shell-alias
The BLT alias is already installed and up to date.
BLT 12 is end-of-life and unmaintained. Upgrade immediately to the latest major release.
See https://docs.acquia.com/blt/#releases-and-versioning
.gitignore does not contain drainpipe ignores. Compare .gitignore in the root of your repository with /var/lib/tugboat/vendor/lullabot/drainpipe/scaffold/gitignore and update as needed.
🪠 [Drainpipe] vendor/lullabot/drainpipe/scaffold/env/dotenv.php' missing from autoload-dev files
Using cached version of task v3.24.0 (05315061a703fc656984315f25813560f06ecd0076b220d07e1ef39f7f00a586)

In BinaryInstaller.php line 214:
                                                                                                                                                                                     
Unable to add newly converted phar "/root/.composer/cache/files/lullabot/drainpipe/bin/task/3.24.0/task_linux_amd64.tar" to the list of phars, a phar with that name already exists  
                                                                                                                                                                                     

[YesCT]

I read https://bugs.php.net/bug.php?id=75101 and I can see how this approach could be a fix for us.

I'm not sure how to reproduce the bug though.

[YesCT]

This looks like an implementation of the suggested quick fix from https://bugs.php.net/bug.php?id=75101

Quick fix would be to copy the file to a temporary location so it has a different name and doesn't get cached.

---

https://www.w3schools.com/php/phptryit.asp?filename=tryphp_compiler

gives a result like 4f06fe1a59 or 050b9c8d10

Seems a good length and character set for adding to a filename.

[deviantintegral]

If you switch to global binaries as in the other PR, this code isn't called for task or local-security-checker.

However, this is still worth fixing given that's opt in and we need to support this setup until at least the next major version of Drainpipe.