Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to avoid 'Unable to add newly converted phar... to the list of ph… #619

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Try to avoid 'Unable to add newly converted phar... to the list of ph… #619

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b59c82f
Try to avoid 'Unable to add newly converted phar... to the list of ph…
beto-aveiga Jul 22, 2024
2ab6db6
Merge branch 'main' into avoid-cache-issue-when-extracting-binaries
mrdavidburns Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/BinaryInstaller.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ protected function installBinary($binary, $version, $url, $sha, $hashalgo = 'sha
else {
$cacheFolder = sys_get_temp_dir() . \DIRECTORY_SEPARATOR . $binary . \DIRECTORY_SEPARATOR . $version;
}
$cacheDestination = $cacheFolder . \DIRECTORY_SEPARATOR . $fileName;
$cacheDestination = $cacheFolder. \DIRECTORY_SEPARATOR . bin2hex(random_bytes(5)) . $fileName;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this mean we effectively invalidate the cache every time, and never use it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I had to do this because there was an error building Tugboat.
This error happened while running the composer install.
I couldn't find any other way.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to only do the random string cache file after we recognize the error that is causing us to do this. This way we still get the benefits of cache for instances where everything is working fine?

$cacheExtractedBinary = $cacheFolder . \DIRECTORY_SEPARATOR . $binary;
$binDestination = $bin . \DIRECTORY_SEPARATOR . $binary;

Expand Down
Loading