Add reusable group ownership middleware#199
Merged
SudiptaPaul-31 merged 4 commits intoJun 27, 2026
Merged
Conversation
|
@Olajcodes Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Collaborator
|
@Olajcodes fix build |
Contributor
Author
|
@SudiptaPaul-31 I have fixed the build workflow. Kindly check through. |
Collaborator
|
@Olajcodes still fails |
Contributor
Author
|
@SudiptaPaul-31 I believe it should work now. I have tested it locally and it ran successfully. Kindly check through. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Pull Request
🔗 Related Issue
Closes #186
📝 Description
This PR adds reusable group ownership middleware to enforce that only the actual owner of a group can perform sensitive actions such as updating or transferring ownership.
The change is necessary to tighten authorization around group management, prevent unauthorized modifications, and centralize ownership checks so they can be reused across multiple endpoints.
🚀 Changes Made
Implemented a reusable middleware that:
Updated sensitive routes to use the middleware:
Added unit tests to validate:
🧪 Testing & Validation
Validation performed:
If yes, explain:
📸 Screenshots (REQUIRED for UI changes)
📋 Contributor Checklist (MANDATORY)
Closes #186)💡 Notes for Reviewer
Key areas to review:
lib/middleware/group-ownership.tsapp/api/groups/[id]/transfer-ownership/route.tsapp/api/rooms/[roomId]/route.tstests/group-ownership.test.tsKnown limitations: