Skip to content

Split marm-console's Knowledge.tsx into per-component files #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lyellr88 merged 2 commits into from
Jul 18, 2026
Merged

Split marm-console's Knowledge.tsx into per-component files #100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94af92e
Split marm-console's Knowledge.tsx into per-component files
claude Jul 18, 2026
6cef780
fix(console): address CodeRabbit review findings on PR #100
claude Jul 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
181 changes: 181 additions & 0 deletions marm-console/artifacts/marm-console/src/components/knowledge/BuildAndDuplicates.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,181 @@
import { useState, useEffect } from 'react';
import { useQueryClient } from '@tanstack/react-query';
import { useBuildConcepts, useMarmConfig, useFilters, useConceptBuild, useConceptDuplicates } from '@/hooks/use-marm-queries';
import { Card, CardContent, CardHeader, CardTitle, CardDescription, Button, Badge, Dialog, DialogContent, DialogHeader, DialogTitle, Table, TableHeader, TableRow, TableHead, TableBody, TableCell, Select, SelectTrigger, SelectValue, SelectContent, SelectItem, Label } from '@/components/ui/core';
import { Play, AlertTriangle } from 'lucide-react';
import type { ConceptBuildInput } from '@/lib/marm-types';

export function BuildConceptsDialog({ open, onOpenChange }: { open: boolean, onOpenChange: (o: boolean) => void }) {
const build = useBuildConcepts();
const { baseUrl } = useMarmConfig();
const queryClient = useQueryClient();
const { data: filters } = useFilters();
const [jobId, setJobId] = useState<string | null>(null);
const { data: jobStatus } = useConceptBuild(jobId || '');
const [scope, setScope] = useState<'session' | 'project' | 'all'>('session');
const [scopeValue, setScopeValue] = useState('');
const [confirmAll, setConfirmAll] = useState(false);

const handleBuild = () => {
const input: ConceptBuildInput =
scope === 'session' ? { session_name: scopeValue } :
scope === 'project' ? { project: scopeValue } :
{ search_all: true };
build.mutate(input, {
onSuccess: (res) => setJobId(res.job_id)
});
};

const isRunning = !!jobId && (!jobStatus || jobStatus.status === 'queued' || jobStatus.status === 'running');
const canSubmit = scope === 'all' ? confirmAll : !!scopeValue;

useEffect(() => {
if (!jobStatus || isRunning) return;
queryClient.invalidateQueries({ queryKey: ['conceptsSummary', baseUrl] });
queryClient.invalidateQueries({ queryKey: ['conceptsSearch', baseUrl] });
queryClient.invalidateQueries({ queryKey: ['conceptsGraph', baseUrl] });
queryClient.invalidateQueries({ queryKey: ['duplicates', baseUrl] });
}, [baseUrl, isRunning, jobStatus, queryClient]);

useEffect(() => {
if (!open) {
setJobId(null);
setScope('session');
setScopeValue('');
setConfirmAll(false);
}
}, [open]);

return (
<Dialog open={open} onOpenChange={(o) => { if(!isRunning) onOpenChange(o); }}>
<DialogContent>
<DialogHeader>
<DialogTitle>Build Concept Graph</DialogTitle>
</DialogHeader>
{!jobId ? (
<div className="py-4 flex flex-col gap-4">
<p className="text-sm text-muted-foreground">
Extract entities and relationships from unstructured memories. Pick exactly one scope.
This requires processing time against the LLM backend.
</p>
<div className="space-y-2">
<Label className="text-xs">Scope</Label>
<Select value={scope} onValueChange={(v: any) => { setScope(v); setScopeValue(''); setConfirmAll(false); }}>
<SelectTrigger><SelectValue /></SelectTrigger>
<SelectContent>
<SelectItem value="session">Session</SelectItem>
<SelectItem value="project">Project</SelectItem>
<SelectItem value="all">All memory (global)</SelectItem>
</SelectContent>
</Select>
</div>
{scope === 'session' && (
<Select value={scopeValue} onValueChange={setScopeValue}>
<SelectTrigger><SelectValue placeholder="Choose a session" /></SelectTrigger>
<SelectContent>
{filters?.sessions.map(s => <SelectItem key={s} value={s}>{s}</SelectItem>)}
</SelectContent>
</Select>
)}
{scope === 'project' && (
<Select value={scopeValue} onValueChange={setScopeValue}>
<SelectTrigger><SelectValue placeholder="Choose a project" /></SelectTrigger>
<SelectContent>
{filters?.projects.map(p => <SelectItem key={p} value={p}>{p}</SelectItem>)}
</SelectContent>
</Select>
)}
{scope === 'all' && (
<label className="flex items-start gap-2 text-sm p-3 bg-amber-500/10 border border-amber-500/20 rounded">
<input type="checkbox" checked={confirmAll} onChange={e => setConfirmAll(e.target.checked)} className="mt-1" />
<span>I understand this processes every memory across every session and project, and may take a while.</span>
</label>
)}
<Button onClick={handleBuild} isLoading={build.isPending} disabled={!canSubmit} className="w-full">
<Play className="w-4 h-4 mr-2" /> Start Build
</Button>
</div>
) : (
<div className="py-6 space-y-4">
<div className="flex items-center justify-between font-mono text-sm border-b pb-2">
<span>Status</span>
<Badge variant={jobStatus?.status === 'error' ? 'destructive' : 'default'} className="uppercase">
{jobStatus?.status || 'Starting...'}
</Badge>
</div>
{jobStatus?.status === 'degraded' && (
<div className="p-3 bg-amber-500/10 text-amber-500 border border-amber-500/20 rounded text-sm flex gap-2">
<AlertTriangle className="w-4 h-4 shrink-0 mt-0.5" />
<p>Degraded mode: {jobStatus.error_code || 'Missing dependencies on server'}</p>
</div>
)}
<div className="grid grid-cols-2 gap-4 pt-2">
<div className="p-4 bg-muted/30 rounded-lg text-center">
<div className="text-2xl font-bold font-mono">{jobStatus?.entities_extracted || 0}</div>
<div className="text-xs text-muted-foreground mt-1">Entities</div>
</div>
<div className="p-4 bg-muted/30 rounded-lg text-center">
<div className="text-2xl font-bold font-mono">{jobStatus?.relationships_created || 0}</div>
<div className="text-xs text-muted-foreground mt-1">Relationships</div>
</div>
</div>
{!isRunning && (
<Button className="w-full mt-4" variant="outline" onClick={() => onOpenChange(false)}>
Close
</Button>
)}
</div>
)}
</DialogContent>
</Dialog>
);
}

export function DuplicatesTab() {
const { data, isLoading } = useConceptDuplicates();

return (
<div className="h-full flex flex-col pb-4">
<Card className="flex-1 flex flex-col overflow-hidden">
<CardHeader>
<CardTitle>Duplicate Candidates</CardTitle>
<CardDescription>Review potential concept duplicates based on similarity. (Read-only)</CardDescription>
</CardHeader>
<CardContent className="flex-1 overflow-auto p-0">
<Table>
<TableHeader className="sticky top-0 bg-muted/80 backdrop-blur">
<TableRow>
<TableHead>Entity A</TableHead>
<TableHead>Entity B</TableHead>
<TableHead className="text-right">Similarity</TableHead>
</TableRow>
</TableHeader>
<TableBody>
{isLoading ? (
<TableRow><TableCell colSpan={3} className="text-center text-muted-foreground h-24">Loading duplicates...</TableCell></TableRow>
) : data?.length === 0 ? (
<TableRow><TableCell colSpan={3} className="text-center text-muted-foreground h-24">No duplicate candidates found.</TableCell></TableRow>
) : (
data?.map((dup, i) => (
<TableRow key={i}>
<TableCell>
<div className="font-mono text-sm">{dup.entity_a.name}</div>
<Badge variant="outline" className="text-[10px] mt-1">{dup.entity_a.type}</Badge>
</TableCell>
<TableCell>
<div className="font-mono text-sm">{dup.entity_b.name}</div>
<Badge variant="outline" className="text-[10px] mt-1">{dup.entity_b.type}</Badge>
</TableCell>
<TableCell className="text-right">
<span className="font-mono text-sm text-amber-500">{(dup.similarity * 100).toFixed(1)}%</span>
</TableCell>
</TableRow>
))
)}
</TableBody>
</Table>
</CardContent>
</Card>
</div>
);
}
Loading
Loading