Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show blocked ads notification #540

Closed
wants to merge 3 commits into from
Closed

Conversation

panchalamitr
Copy link

@panchalamitr panchalamitr commented Aug 15, 2021

I have added one extra notification, which shows, how many times ads are blocked and which ads are blocked with use of our application.

For that I have added

  1. Extra notification channel (from where user can disable this notification).

I love to use your app, so as an Android Developer, I want to contribute.

Please let me know if you like my idea. Thank you so much for making this App.

@M66B
Copy link
Owner

M66B commented Aug 15, 2021

What is the source of the images?
Do you agree to the license and copyright? See the contributing section in the description.

@panchalamitr
Copy link
Author

Yes, I am agree to license and copyright

I have added image from

https://www.flaticon.com/free-icon/ad_814158?term=ads%20block&page=1&position=2&page=1&position=2&related_id=814158&origin=search

Flaticon License
Free for personal and commercial purpose with attribution.
License summary
Our license allows you to use the content:

For commercial and personal projects
On digital or printed media,
For an unlimited number of times and perpetually
Anywhere in the world
To make modifications and derived works

@M66B
Copy link
Owner

M66B commented Aug 15, 2021

I have a problem with "with attribution".

@panchalamitr
Copy link
Author

panchalamitr commented Aug 15, 2021

It's ok, I will remove this icon and can use our ic_security_white_24dp.png icon
Or I can share that icon's attribute (link) to my social media platform so it will not create an issue.

@panchalamitr
Copy link
Author

Done changes, removed that images and used existing one. Thanks.

@M66B
Copy link
Owner

M66B commented Aug 15, 2021

How about the other remarks?

@panchalamitr
Copy link
Author

panchalamitr commented Aug 15, 2021

Remarks?, sorry, I did not get you.

Removed image (screenshot which shows third party icon) from this (comment section as well).

Let me know if anything required, I will update it,

@panchalamitr
Copy link
Author

Hi, let me know if I need to update anything from my side. Thanks,

@M66B
Copy link
Owner

M66B commented Aug 17, 2021

There are still plenty of review items open ...

@panchalamitr
Copy link
Author

Oh ok, I can understand. Thanks for your update.

@M66B M66B closed this Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants