Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User preference to skip beta updates #545

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

JnnyRdng
Copy link
Contributor

This PR adds a new user preference under Settings > Options to toggle notifying for beta release updates.
This option is turned off by default, and when off releases such as 2.330 beta will not trigger a notification, helping those users that like to remain on stable versions.

@M66B
Copy link
Owner

M66B commented Sep 12, 2024

Did you test this change?

@JnnyRdng
Copy link
Contributor Author

Hi! Yeah I've tested it over adb on a Pixel 7a. I turned up the frequency so I didn't have to wait half a day, and had to turn off the check to Util::hasValidFingerprint to get into the update method locally, but once in I've observed the desired behaviour.

Toggle off: eu.faircode.netguard I Skipping beta release '2.330 beta' due to update preferences

Toggle on: eu.faircode.netguard I Up-to-date current version 2.330

@M66B M66B merged commit 0d8b48a into M66B:master Sep 13, 2024
@M66B
Copy link
Owner

M66B commented Sep 13, 2024

This will be part of the next release, which might take some time.

@M66B
Copy link
Owner

M66B commented Sep 13, 2024

Thanks for the contribution!

@JnnyRdng JnnyRdng deleted the feature/skip-beta-release branch September 13, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants