Restore rental time left#3
Open
AlexanderTrysMine wants to merge 2 commits intoMCCitiesNetwork:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey gamers,
This PR just adds back a readable “time left” display for rentals using the lease end date the plugin already stores.
So instead of only showing:
endfoundation-04
it’ll show something like:
endfoundation-04 (12d 3h 5m)
It also adds the same time-left value to /realty info, and exposes it as a reusable placeholder so signs/profiles can show it too.
It’s mostly a display/quality-of-life PR. The only real implementation compromise is that the list command now does an extra lease lookup for each rented
Not sure if this is something you planned already to add but its a feature I really liked.