Implement Soroban Contract Pattern Library, Finding Deduplication, Rule Testing Sandbox, and Impact Scoring#546
Merged
mijinummi merged 1 commit intoJun 25, 2026
Conversation
…le Testing Sandbox, and Impact Scoring - Add ContractPatternLibrary (src/patterns/stellar/) for registering, looking up, and detecting contract patterns in Soroban AST - Add DeduplicationEngine (src/findings/deduplication/stellar/) for detecting and merging duplicate findings across analysis stages - Add RuleSandbox (tests/sandbox/stellar-rules/) for isolated rule testing against sample Soroban contracts - Add ImpactScorer (src/scoring/impact/stellar/) for assigning impact scores based on exploitability, reachability, value-at-risk, and business impact Closes MDTechLabs#494 Closes MDTechLabs#493 Closes MDTechLabs#492 Closes MDTechLabs#491
|
@NteinPrecious Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements four new features for Soroban/Stellar contract analysis:
#494: Soroban Contract Pattern Library (
src/patterns/stellar/)ContractPatternLibraryclass for registering, looking up, and detecting contract patternsContractPattern,PatternCategory,PatternSeverity,PatternMatch,PatternLookupOptions#493: Soroban Finding Deduplication Engine (
src/findings/deduplication/stellar/)DeduplicationEngineclass for detecting and merging duplicate findingsDedupKey,DedupStrategy,FindingGroup,DedupConfig,DedupResult#492: Soroban Rule Testing Sandbox (
tests/sandbox/stellar-rules/)RuleSandboxclass for isolated rule testing against sample contractsrunRule,runAllRules,resetSandbox,createSandboxAPIs#491: Soroban Rule Impact Scoring (
src/scoring/impact/stellar/)ImpactScorerclass for assigning impact scores beyond severityImpactScore,ImpactFactor,ImpactCategory,ImpactReport,ImpactScoringConfigImpactReportwith overall impact, per-category breakdown, and recommendationsAll implementations follow existing TypeScript/NestJS patterns in the codebase with async/await, proper JSDoc comments, and comprehensive unit tests (67 passing).
Closes #494
Closes #493
Closes #492
Closes #491