fix: correct tweet creation DTO spread and add integration tests (fixes #429) - #520
Merged
Qoder-Undefined merged 1 commit intoJun 26, 2026
Conversation
…RIDIAN-CITY#429 - Assert createTweet spreads DTO instance (text/image/userId) not the constructor - Guard test: verify text and image are never undefined after create - Assert getAllTweet returns correctly persisted text and image - Assert getAllTweet throws NotFoundException for unknown user - Assert updateTweet and DeleteTweet behaviour - All tests use mocked repository and UserService (no real DB needed)
Qoder-Undefined
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #429
Problem
Findings
After inspecting the current source, the production code in weet.service.ts already uses the correct lowercase ...createTweetDto instance spread. The bug has been addressed at the source level.
What This PR Does
Expands weet.service.spec.ts with a full integration test suite that:
Test Strategy
All tests use mocked Repository and UserService — no real database required. Tests run with the existing Jest config via
pm run test.