Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fork #1

Merged
merged 1 commit into from
Jun 1, 2024
Merged

Fork #1

merged 1 commit into from
Jun 1, 2024

Conversation

roanutil
Copy link
Member

@roanutil roanutil commented May 17, 2024 •
edited
Loading

  • Port tests to XCTest
  • Change swiftformat config
  • Change SwiftLint config
  • Resolve lint warnings
  • Port documentation to DocC
  • Change CI workflow
  • Remove Spectre dependency
  • Change PathKit dependency to MFB Tech fork
  • Add linux dev container
  • Fix build error in tests on linux

@roanutil roanutil requested review from r-jarvis and sam-mfb May 17, 2024 18:46
@roanutil
Fork
1176b89 
fork
r-jarvis
r-jarvis reviewed Jun 1, 2024
View reviewed changes
Copy link

@r-jarvis r-jarvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency of our repos, should we also add SwiftFormat to this project?

@r-jarvis
Copy link

r-jarvis commented Jun 1, 2024

I'm seeing a handful of Sendable warnings. Did you want to handle that in this initial PR or wait on it?

@roanutil
Copy link
Member Author

roanutil commented Jun 1, 2024

I'm seeing a handful of Sendable warnings. Did you want to handle that in this initial PR or wait on it?

Wait on it. I tried to keep this PR "structural".

@roanutil
Copy link
Member Author

roanutil commented Jun 1, 2024

For consistency of our repos, should we also add SwiftFormat to this project?

What do you mean? Isn't there already a config file for it?

@roanutil roanutil merged commit 41785a5 into main Jun 1, 2024
3 checks passed
@roanutil roanutil deleted the fork branch June 1, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r-jarvis r-jarvis r-jarvis approved these changes

@sam-mfb sam-mfb Awaiting requested review from sam-mfb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roanutil @r-jarvis