You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unused loop variables (i, j, k) in /pre_process/m_patches.fpp. They appear unused but are required by the @:analytical() macro during ./mfc.sh test.
Several rank mismatch issues in /post_process/m_data_output.fpp. This relates to silo package, wondering if this required to be fixed.
An example is attached:
err = DBADDIOPT(optlist, DBOPT_LO_OFFSET, lo_offset)
| ! rank-1 array
......
err = DBADDIOPT(optlist, DBOPT_EXTENTS_SIZE, 2)
| ! scalar
Warning: Rank mismatch between actual argument at (1) and actual argument at (2) (scalar and rank-1)
PR Type
Enhancement
Description
Remove unused variables and dummy arguments across modules
Fix compiler warnings for uninitialized variables
Correct MPI data type declarations for proper addressing
Add conditional compilation guards for unused code sections
Changes diagram
flowchart LR
A["Compiler Warnings"] --> B["Remove Unused Variables"]
B --> C["Fix MPI Data Types"]
B --> D["Add Conditional Guards"]
B --> E["Initialize Variables"]
C --> F["Clean Code"]
D --> F
E --> F
• Remove unused variables, subroutines, dummy variables, etc. to eliminate compiler warnings
• Handle warnings that persist due to different compilation units marked by #ifdef
• Work around issues by enclosing offending variables with corresponding #ifdef and #endif tags
Requires further human verification:
• Verification that all compiler warnings are actually eliminated during build
• Testing that the code still functions correctly after variable removal/reorganization
• Confirmation that performance is not negatively impacted by the changes
Variable initialization code is duplicated across multiple functions. The same initialization patterns for variables like Re_K, rho_K, gamma_K, etc. appear in several subroutines with slight variations, which could lead to maintenance issues.
Local copies of arrays are created (alpha_K_local, alpha_rho_K_local) but the original intent parameters are not used in computations, which may not reflect the intended behavior and could introduce subtle bugs.
The parameter order in the subroutine signature has been changed, which could break existing function calls if they rely on positional arguments rather than named arguments.
✅ Use correct variable for allocationSuggestion Impact:The commit directly implements the suggested fix by replacing fd_number_in with fd_number in the allocate statement, fixing the bug with optional parameter handling
The variable fd_number_in is used in the allocation but should be replaced with the local variable fd_number that handles the optional parameter logic.
Why: The suggestion correctly identifies a critical bug. The code uses an optional argument fd_number_in directly in an allocate statement. If fd_number_in is not provided, this will lead to a runtime error. The fix correctly proposes using the local variable fd_number, which is designed to handle the optional logic.
High
✅ Fix preprocessor directive syntaxSuggestion Impact:The suggestion was directly implemented - both #endif directives in the file had their macro names removed to follow standard preprocessor syntax
code diff:
-#endif MFC_PRE_PROCESS+#endif
@:PROHIBIT(surface_tension .and. sigma < 0._wp, &
"sigma must be greater than or equal to zero")
@@ -340,7 +340,7 @@
@:PROHIBIT(surface_tension .and. f_is_default(patch_icpp(i)%cf_val), &
"patch_icpp(i)%cf_val must be set if surface_tension is enabled")
end do
-#endif MFC_PRE_PROCESS+#endif
The #endif directive should not include the macro name. In Fortran preprocessor directives, #endif should stand alone without the condition name.
#ifdef MFC_PRE_PROCESS
integer :: i
-#endif MFC_PRE_PROCESS+#endif
Suggestion importance[1-10]: 4
__
Why: The suggestion correctly points out that the standard preprocessor syntax for #endif does not include the macro name. While some compilers might tolerate this, it's non-standard and harms portability. The fix improves code correctness and style.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Description
This is the latest progress of code tidying.
Fixes #845
Type of change
./mfc.sh build --debugA few issues remaining
For example:
Adding a local variable only to silence a warning:
which I feel is not necessary.
@:analytical()macro during./mfc.sh test.An example is attached:
PR Type
Enhancement
Description
Remove unused variables and dummy arguments across modules
Fix compiler warnings for uninitialized variables
Correct MPI data type declarations for proper addressing
Add conditional compilation guards for unused code sections
Changes diagram
Changes walkthrough 📝
24 files
Remove unused variables and fix MPI typesAdd conditional compilation guard for variableFix parameter order and optional argumentsInitialize variables and add conditional guardsFix variable scope and initializationRemove unused variables and fix declarationsFix parameter order in function callsRemove unused variables and fix comparisonsRemove unused variable declarationRemove unused parameters from subroutinesRemove unused loop variableRemove unused stability criterion variablesFix parameter order in function callsAdd conditional compilation for variablesFix parameter order in function callsFix parameter order in function callsRemove unused loop variablesRemove unused variables and fix callsRemove unused variables from subroutineComment out unused gradient magnitude variablesRemove unused field variablesFix variable initialization and declarationsComment out unused gradient variablesRemove duplicate parameter declarations1 files
Improve precision-specific tolerance handling