-
Notifications
You must be signed in to change notification settings - Fork 110
Update CMakeLists.txt to link new header files for NVTX v3 for CUDA 1… #949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update CMakeLists.txt to link new header files for NVTX v3 for CUDA 1… #949
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #949 +/- ##
=======================================
Coverage 44.06% 44.06%
=======================================
Files 68 68
Lines 18220 18220
Branches 2292 2292
=======================================
Hits 8029 8029
Misses 8821 8821
Partials 1370 1370 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
works on runners but i'm seeing some weird behavior with nvhpc/25.5 on Phoenix (which is not used on the runners right now, 24.5 is). will try some things out myself before merging. |
Let me know if there's anything I can check on my side. I'll add 24.5 to the list to check. Do the runners run all tests? Is there a specific test I can check our can you add the errors here if you think they're relevant to other systems? |
Well 25.5 fails for me on Phoenix w/ your PR but that computer is currently running v24.5 when the runners go - so the current PR has v24.5 working fine. I can change this PR so it loads the latest modules (I should probably just do that) and then we will see what breaks/doesn't break. When I tried doing it myself on Phoenix it just broke in a strange way so I'll try again later. |
Hmm I cannot get this working with nvhpc v25.5 on my end (using your/our changes). Can you check out the latest master branch and see if you can compile? If you don't mind, can you give me details of your compiler stack? |
User description
…2.9+
Description
Adding a switch in CMakeLists.txt to locate and link the appropriate NVTX headers for CUDA 12.9+, while maintaining the previous compatibility with <= CUDA 12.8.
Type of change
Please delete options that are not relevant.
Scope
How Has This Been Tested?
Builds with both nvhpc 25.3 and 25.5 (CUDA 12.8 and 12.9) with
--debug
and--gpu
flags enabled.Solve 1x randomly chosen 2D example problem per build.
Test Configuration:
Checklist
docs/
)examples/
that demonstrate my new feature performing as expected.They run to completion and demonstrate "interesting physics"
./mfc.sh format
before committing my codePR Type
Bug fix
Description
Update CMakeLists.txt to support NVTX v3 for CUDA 12.9+
Add conditional linking for different CUDA versions
Maintain backward compatibility with CUDA <= 12.8
Include nvtx3 component and cudalib linker option
Diagram Walkthrough
File Walkthrough
CMakeLists.txt
Update NVTX linking for CUDA version compatibility
CMakeLists.txt