Skip to content

fix: sky clipping #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lonelyicer merged 2 commits into from
Oct 21, 2025
Merged

fix: sky clipping #70

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a616e8
fix: sky clipping
lonelyicer Oct 21, 2025
2af3c68
chore: apply suggestions
lonelyicer Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions src/main/java/com/altnoir/mia/client/renderer/AbyssBrinkDimEffects.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,25 @@ public boolean isFoggyAt(int x, int y) {
public boolean renderSky(ClientLevel level, int ticks, float partialTick, Matrix4f modelViewMatrix, Camera camera, Matrix4f projectionMatrix, boolean isFoggy, Runnable setupFog) {
ResourceLocation sunTexture = MiaUtil.miaId("textures/skybox/abyss_brink.png");

var oldProjectionMatrix = RenderSystem.getProjectionMatrix();
var projection = new Matrix4f(oldProjectionMatrix);

float m22 = projection.m22();
float m32 = projection.m32();

float near = m32 / (m22 - 1.0F);
float far = 1.0E6F;

projection.m22((far + near) / (near - far));
projection.m32((2.0F * far * near) / (near - far));

RenderSystem.setProjectionMatrix(projection, VertexSorting.ORTHOGRAPHIC_Z);

RenderSystem.setShaderColor(1.0F, 1.0F, 1.0F, 1.0F);
RenderSystem.setShader(GameRenderer::getPositionTexShader);
RenderSystem.setShaderTexture(0, sunTexture);
RenderSystem.enableBlend();
RenderSystem.defaultBlendFunc();

PoseStack poseStack = new PoseStack();
poseStack.mulPose(modelViewMatrix);
Expand All @@ -59,6 +75,10 @@ public boolean renderSky(ClientLevel level, int ticks, float partialTick, Matrix
bufferbuilder.addVertex(pose, -size - playerX, height, size - playerZ).setUv(0.0F, 1.0F);

BufferUploader.drawWithShader(bufferbuilder.buildOrThrow());

RenderSystem.setProjectionMatrix(oldProjectionMatrix, VertexSorting.ORTHOGRAPHIC_Z);
RenderSystem.disableBlend();

return true;
}
}