Skip to content

Conversation

@lonelyicer
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings December 3, 2025 16:26
@github-actions github-actions bot added the enhancement New feature or request label Dec 3, 2025
@github-actions
Copy link

github-actions bot commented Dec 3, 2025

Game Test Results

✅ Success

Metric Value
Total Tests 1
Passed 1
Failed 0
Duration 352.8 ms

Workflow run: #281

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds comprehensive entity customization capabilities to the trial spawner system, allowing spawned entities to be equipped with items, given potion effects, and have their attributes modified.

Key changes:

  • Introduces a builder pattern (EntityTableBuilder) for fluent configuration of entity equipment, effects, and attributes
  • Adds JSON serialization/deserialization support for the new entity configuration options
  • Implements application logic to equip mobs with items, apply potion effects, and modify attributes when spawned

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/main/java/com/altnoir/mia/datagen/MiaTrialSpawnerProvider.java Adds example usage demonstrating the new entity builder API with equipped zombies and skeletons
src/main/java/com/altnoir/mia/core/spawner/records/EntityTableInstance.java Extends the entity table record to store equipment, effects, and attribute modifiers
src/main/java/com/altnoir/mia/core/spawner/AbyssTrialSpawnerManager.java Implements JSON parsing logic for equipment, effects, and attribute modifiers
src/main/java/com/altnoir/mia/core/spawner/AbyssTrialSpawnerDataProvider.java Adds EntityTableBuilder class with fluent API for entity configuration and JSON serialization support
src/main/java/com/altnoir/mia/core/spawner/AbyssTrialSpawner.java Implements applyEntityConfiguration method to apply equipment, effects, and attributes to spawned mobs
src/generated/resources/data/mia/mia/trial_spawner/example_equipped_zombie.json Generated JSON configuration file for the equipped zombie example

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@lonelyicer lonelyicer marked this pull request as draft December 6, 2025 09:49
@lonelyicer lonelyicer self-assigned this Dec 6, 2025
@lonelyicer lonelyicer linked an issue Dec 6, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Abyss Trial Spawner

2 participants