Skip to content

Avoid using multiple processes for downloads #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2022
Merged

Avoid using multiple processes for downloads #375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions wfdb/io/download.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import json
import multiprocessing
import multiprocessing.dummy
import os
import posixpath

Expand Down Expand Up @@ -566,7 +566,7 @@ def dl_files(db, dl_dir, files, keep_subdirs=True, overwrite=False):
print("Downloading files...")
# Create multiple processes to download files.
# Limit to 2 connections to avoid overloading the server
pool = multiprocessing.Pool(processes=2)
pool = multiprocessing.dummy.Pool(processes=2)
pool.map(dl_pn_file, dl_inputs)
print("Finished downloading files")

Expand Down
4 changes: 2 additions & 2 deletions wfdb/io/record.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import datetime
import multiprocessing
import multiprocessing.dummy
import posixpath
import re

Expand Down Expand Up @@ -3090,7 +3090,7 @@ def dl_database(
print("Downloading files...")
# Create multiple processes to download files.
# Limit to 2 connections to avoid overloading the server
pool = multiprocessing.Pool(processes=2)
pool = multiprocessing.dummy.Pool(processes=2)
pool.map(download.dl_pn_file, dl_inputs)
print("Finished downloading files")

Expand Down