Complain when p_signal has low bit depth so that saving works reliably
#546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivorforce
force-pushed
the
complain-low-bitdepth
branch
from
bd3bedd to
fa92cb6
Compare
Ivorforce
force-pushed
the
complain-low-bitdepth
branch
from
fa92cb6 to
ac48683
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may not be the best solution, but it's one that works.
I tried modifying
adcto convert to 64 bit automatically instead on demand, but that wasn't enough. Only convertingp_signalfor all of thewrsampprocess works. So there's definitely other factors at play.An alternative solution might be to make the bounds calculation work with 32 bit, or at least be robust to it. But I'm not sure how feasible this is, since I can't figure out where exactly it's going wrong.
Making sure people use high-precision data for saving accuracy makes sense to me anyhow. Data may be lost elsewhere otherwise accidentally.