add color image to backprojection #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanhhughes
force-pushed
the
feature/color_backprojection
branch
from
402205f to
62a1561
Compare
Collaborator
Author
|
@marcusabate for posterity, I think rgb vs. bgr ordering should work correctly now: I'm planning on finally merging this in when CI passes, I went ahead and also added some stuff that might be useful for background reconstruction for not blending the out-of-view default color (black) with actual color observations in Hydra/Khronos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@marcusabate Going to do my cleanup and fix the bgr/rgb ordering issue later this afternoon, but figured it would be good to actually remember to PR this